#19077: Greatly speed up equality check of equal graphs
-------------------------------------+-------------------------------------
Reporter: novoselt | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Andrey | Reviewers: Jori Mäntysalo
Novoseltsev | Work issues:
Report Upstream: N/A | Commit:
Branch: | 959c85d02f96b679a1bc082543359554d496eeb7
u/novoselt/graph_eq | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
I agree with the new version of the code. I would have prefered if you had
left it where it was, i.e. indented after a 'else'. I consider it a matter
of "personal taste", and I believe that it is 'better manners' not to
force your own taste on what was there before you arrived. Not very
important.
Besides this, I agree with your code so you can consider it positively
reviewed (let's way for the patchbot's green light, just in case).
Thanks,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19077#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
