#19113: LatticePoset: Return type category of product()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: poset, | Merged in:
latticeposet | Reviewers:
Authors: Jori Mäntysalo | Work issues:
Report Upstream: N/A | Commit:
Branch: | 3346ee8d02a1db3e13860a370caf40ca55bf441d
u/jmantysalo/latticeposet__return_type_category_of_product__| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Jori M\xe4ntysalo', 'oldvalue': ''}):
* status: new => needs_review
* commit: => 3346ee8d02a1db3e13860a370caf40ca55bf441d
* author: => Jori Mäntysalo
Comment:
Replying to [comment:3 tscrim]:
> The difference is in the constructions, `product` goes through
`FiniteLatticePoset` whereas `ordinal_product` goes through `LatticePoset`
(which sets category). So it's a code path problem, not anything with the
categories.
OK. Corrected that.
> IMO, one should implement an `__init__` method for each of
`*LatticePoset` classes which handles telling `Poset` which category to
use. I'm not so much in favor of these construction functions because they
cause problems exactly like this one.
Should this be part of #18776?
This is now ready for review. I corrected the bug, added the definition of
the function and added a test.
Also there is non-relating change that rearranges the functions in the
"Other & not yet classified" part of index and changes some phrasing.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3346ee8d02a1db3e13860a370caf40ca55bf441d
3346ee8]||{{{Right category for product() of [semi]lattices.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19113#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
