#18600: Fix several methods for sparse polynomials
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: commutative | Resolution:
algebra | Merged in:
Keywords: sparse polynomial | Reviewers: Vincent Delecroix
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18600 | f2b57e3c6d4ad560d378d87bad8490f9efbb4b0b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
- ` if not isinstance(degree, int) and not isinstance(degree, Integer)` ->
`not isinstance(degree, (int,Integer))`.
- after `OUTPUT:` in the docstring of `newton_slopes` you should add a
line break
- you can do one liners (you are not obliged though)
{{{
d = {degree-k: v for k,v in self.__coeffs.iteritems() if degree >= k}
}}}
- why are you keeping a method `newton_slopes` in both
`polynomial_element.Polynomial` and
`polynomial_element_generic.Polynomial_generic_sparse`? The algorithm does
not seem to use much about the sparse structure. Moreover, why their
arguments differ?
--
Ticket URL: <http://trac.sagemath.org/ticket/18600#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
