#15875: Add is_subposet
-------------------------------------+-------------------------------------
Reporter: csar | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: posets | Merged in:
Authors: Jori Mäntysalo | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/is_subposet | 00daf69f415aa6f10410dc65841ebe48f592c88b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:30 tscrim]:
> The current docstring is much more clear than previously. Thank you.
Could you also add something about the elements/labels to the `NOTE::`
block too, something like `(i.e., up to relabeling)` after the
`*isomorphic*` to further emphasize this?
Done.
> You should add some more examples contrasting the two methods. In
particular, one where the `subposet` returns `False` as the isomorphism
one returns `True`. Also you have some `$` in the docstring.
?? First example is already like that. `Q.has_isomorphic_subposet(P)`
returns `True`. Removed `$`.
> I think because they are the same elements and because facade is more
specific to use in Sage, we should have the subposet not depend on being a
facade.
OK. This patch fixes it to other direction, but needs more work:
{{{
sage: P = Poset({1:[2]}, facade=True)
sage: Q = Poset({1:[2]}, facade=False)
sage: P.is_subposet(Q)
True
sage: Q.is_subposet(P)
. . .
ValueError: <class 'sage.combinat.posets.elements.FinitePoset_with---
. . .
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/15875#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
