#18118: transducer: convenience option for process words iteratively (and 
showing
output)
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  finite state       |   Resolution:
  machines                           |    Merged in:
       Keywords:  sd66               |    Reviewers:  Clemens Heuberger
        Authors:  Daniel Krenn       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/dkrenn/fsm       |  29a54c3b707c6b6b62494bea8e32dc10f4fb4ee7
  /iter_process-simple               |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by dkrenn):

 * status:  needs_work => needs_review
 * commit:  137cbf9a94356ca0ebef56de92125da4fff44d77 =>
     29a54c3b707c6b6b62494bea8e32dc10f4fb4ee7
 * work_issues:  see comment 10 =>


Comment:

 Replying to [comment:11 cheuberg]:
 > * Added two minor commits, please cross-review

 Done....ok.

 > * The description of `iter_process` does not explain why a user would
 want to have a simple iterator. Could you elaborate and/or provide an
 illustrating example (for simplicity, for finite input instead of an
 infinite word) on how the standard and the simple iterator differ?
 > * IMHO, there should be doctests for all error conditions in
 `_iter_process_simple_`
 > * I do not understand the code of `_iter_process_simple_`:
 >   - why do you need to set `output = outputs[0]` and iterate over
 `output` instead of `outputs[0]`?
 >   - why do you reset `outputs[0] = []` at the end?
 >
 >   Could you please add comments on that?
 > * Please add a `SEE ALSO` block for `_iter_process_simple_` even if it
 does not currently show up in the reference manual.

 Addressed all these comments in the new commits.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=4bc8bc63fb82902e5800e0b238cc8f542417ce66
 4bc8bc6]||{{{add additional examples to show difference between
 'simple'-option and not using it}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=f00e9046d555a6e330e5cd5047947933db844940
 f00e904]||{{{seealso block in _iter_process_simple_}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=a28221b55b4c2fdc3702a756c5391105b8ac7c75
 a28221b]||{{{minor simplifiction of code and add a comment explaining
 resetting of output}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=29a54c3b707c6b6b62494bea8e32dc10f4fb4ee7
 29a54c3]||{{{doctests for error conditions and rephrase these errors to
 get more information when raised}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18118#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to