#19218: Restrict skew partition input to Schur basis and implement a skew Schur
method
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  combinatorics      |   Resolution:
       Keywords:  schur, symmetric   |    Merged in:
  functions                          |    Reviewers:
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  fee5688edd81a3e3d185c509f32455607fad31fb
  public/combinat/skew_schur-19218   |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by darij):

 {{{
 +            s = self.realization_of().schur()
 +            from sage.combinat.skew_partition import SkewPartitions
 +            import sage.libs.lrcalc.lrcalc as lrcalc
 +            if x not in SkewPartitions():
 +                raise ValueError("not a valid skew partition")
 }}}
 Shouldn't the if-check be before the other instructions? Maybe even in the
 element constructor, before calling the `skew_schur` function, seeing that
 Python is usually slow at handling exceptions?

 Other than this, the patch looks good if someone can check that (1)
 elements of the base ring and elements coercing into the base ring still
 coerce OK (please check on various bases), and (2) the doctests pass. (I
 don't have time to fire up Sage...) Glad you caught this bug, Travis!

--
Ticket URL: <http://trac.sagemath.org/ticket/19218#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to