#19218: Restrict skew partition input to Schur basis and implement a skew Schur
method
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  combinatorics      |   Resolution:
       Keywords:  schur, symmetric   |    Merged in:
  functions                          |    Reviewers:
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  14e6047d20bb18574747efba1b64a83349f709aa
  public/combinat/skew_schur-19218   |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Replying to [comment:2 darij]:
 > Shouldn't the if-check be before the other instructions?

 Good point, done.

 > Maybe even in the element constructor, before calling the `skew_schur`
 function, seeing that Python is usually slow at handling exceptions?

 This is the first thing that is checked in the element constructor. This
 is the first thing that is checked by the Schur functions element
 constructor, and exception generation and handling is faster than checking
 if something is a skew partition a second time. Although if you really
 want speed, you probably shouldn't use the element constructor (as that
 also goes through the coercion framework first).

 > Other than this, the patch looks good if someone can check that (1)
 elements of the base ring and elements coercing into the base ring still
 coerce OK (please check on various bases), and (2) the doctests pass. (I
 don't have time to fire up Sage...) Glad you caught this bug, Travis!

 Chances are I could probably remove the coercion of elements into the base
 ring because that should be handled by the coercion framework beforehand
 (as this is the conversion step). However that seemed too likely to be a
 can of worms for me to change it here...

--
Ticket URL: <http://trac.sagemath.org/ticket/19218#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to