#17600: AsymptoticGrowthElement
-------------------------------------+-------------------------------------
Reporter: behackl | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: asymptotics, | Reviewers: Daniel Krenn
gsoc2015 | Work issues:
Authors: Benjamin Hackl, | Commit:
Daniel Krenn | ac5541719eb6ec9605b7e221ffc64d8fc83781e1
Report Upstream: N/A | Stopgaps:
Branch: |
u/cheuberg/asy/growthGroup |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by cheuberg):
I started reviewing this ticket and added three reviewer commits, one of
which is not shown in trac.
Comments so far:
- I think that the following behaviour does not conform to the use of the
parameter `category` in `Parent` ("If category is a list or tuple, a
!JoinCategory is created out of them."):
{{{
sage: import sage.rings.asymptotic.growth_group as agg
sage: agg.GenericGrowthGroup(ZZ, category=(Posets(), Groups()))
Traceback (most recent call last):
...
ValueError: (Category of posets, Category of groups) is not a subcategory
of Join of Category of groups and Category of posets
}}}
Compare this with
{{{
sage: Parent(category=(Posets(), Groups())).category()
Join of Category of groups and Category of posets
}}}
- `GenericGrowthElement` - class documentation: "abstract implementation"
sounds contradictory.
- `GenericGrowthElement.__init__`: first and second tests seem to do the
same thing.
--
Ticket URL: <http://trac.sagemath.org/ticket/17600#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
