#18223: cartesian products with orders
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.7
Component: categories | Resolution:
Keywords: sd67 | Merged in:
Authors: Daniel Krenn | Reviewers: Benjamin Hackl
Report Upstream: N/A | Work issues:
Branch: u/behackl/cat | Commit:
/cartesian-product-posets | 0a74ff134169bd9e1fa9d50eb061f69c19fe351e
Dependencies: #18586 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Hi Benjamin,
Replying to [comment:21 behackl]:
> Thanks for having a look at the code Vincent! I'd like to add some more
comments as well.
>
> Replying to [comment:18 vdelecroix]:
> > 1. I think that the class `CartesianProductPosets` would better be
somewhere in `combinat/posets` rather in `sets/cartesian_product`. It is
always better to split files.
>
> Currently, I like the idea that both "types" of cartesian products can
be found in the same file; I'm not quite sure if it would really be more
clean to move this code to some other file. In any case, I don't really
have any arguments for or against moving the code, I'll leave this
decision to those with more experience.
It is not two disjoint types of `CartesianProduct`. One inherits from the
other.
Some arguments for the splitting:
- there at least one antecedant:
`sage.groups.group_semidirect_product.GroupSemidirectProduct`
- if we start populating `sets.cartesian_product` it might become very
huge
- it is (up to `categories/*`) how the code is organized in the source.
If you are looking for features of poset you look in
`sage.combinat.posets` (ideally it would even be `sage.posets`).
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18223#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
