#18223: cartesian products with orders
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.7
Component: categories | Resolution:
Keywords: sd67 | Merged in:
Authors: Daniel Krenn | Reviewers: Benjamin Hackl
Report Upstream: N/A | Work issues:
Branch: u/behackl/cat | Commit:
/cartesian-product-posets | 0690e716b925505dc34b77338af0da8f35fc53a4
Dependencies: #18586 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by behackl):
* status: needs_review => needs_info
* reviewer: => Benjamin Hackl
* branch: u/dkrenn/cat/cartesian-product-posets => u/behackl/cat
/cartesian-product-posets
* commit: ef15d6c3f9f78452897b760fdf6d828353c0b8c1 =>
0690e716b925505dc34b77338af0da8f35fc53a4
Comment:
Hello!
I've started to review this ticket and merged it into 6.9.beta5. Here are
some comments:
- The changes in `covariant_functorial_construction.py` look good to me.
- Regarding the changes in `categories/sets_cat.py`:
- I've added a small reviewer commit to improve the language in the
docstring of `cartesian_product`.
- Overall, these changes also look good to me. I only have one question
regarding the `extra_category` keyword: should it be possible to pass
lists (or some other iterable) of categories to `extra_category`, or is
there no use case for that?
As far as I can see, everything else regarding these changes has been
discussed on #18586.
I'll report back as soon as I had a look at the remaining changes.
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=ba5dab93e6c7b33eeefc0c937dd2a7d11098807a
ba5dab9]||{{{update docstring and complete doctests}}}||
||[http://git.sagemath.org/sage.git/commit/?id=55a7020df64790be37b1bb4527f74444bc21a602
55a7020]||{{{create class for cartesian products of posets}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6ed924696625f67a5e0e814c758ca5b53885bdcc
6ed9246]||{{{method "le"}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4c9f72ce4920838b49e87bc8efd05ce6c6aecdef
4c9f72c]||{{{methods for comparing lexicographically and component-
wise}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e589e9b6f474c1ae87781e135a462c8717c27700
e589e9b]||{{{create Element: implement <=, <, >=, >}}}||
||[http://git.sagemath.org/sage.git/commit/?id=69335cc0f8d0e4344804b3ca1de76471a8a91574
69335cc]||{{{write a class description}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9352031b310b81f83c09ecac11b1ce15163f55f9
9352031]||{{{change one word in docstring}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ef15d6c3f9f78452897b760fdf6d828353c0b8c1
ef15d6c]||{{{deal with categories: CartesianProductPosets should be in
Posets()}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d34c1fa9d827a0532efc39f404f50ed2d2ff4cd5
d34c1fa]||{{{Merge branch 'u/dkrenn/cat/cartesian-product-posets' of
git://trac.sagemath.org/sage into 6.9.beta5}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0690e716b925505dc34b77338af0da8f35fc53a4
0690e71]||{{{improve language in cartesian_product docstring}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18223#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
