#18376: New encoding structure for linear codes
-------------------------+-------------------------------------------------
Reporter: | Owner:
dlucas | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
coding theory | Work issues:
Keywords: | Commit:
Authors: David | d132d3cfde4cb174cd5a03e3d6d56d51f5752cc7
Lucas | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dlucas/encoder |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by jsrn):
Hi,
1st step of review: looking at what the patchbot complains about:
- There is a function in `sage.coding.encoder` without a test. Is it the
abstract `generator_matrix` that's causing it?
- The mystic `startup_modules` fails. This turns out to mean that the
patchbot has detected that a new module is loaded at Sage startup: a thing
that is nowadays attempted to keep a lid on by replacing normal imports
with `lazy_import`. The new module is `sage.coding.encoder`. I'm pretty
sure that this is due to line 3660 of `linear_code` which imports
`encoder`. It doesn't seem possible to remove this import or change it to
`lazy_import` since `Encoder` is referred just below. But what if
`linear_code` itself was lazily imported in `sage.coding.all`? Some care
possibly needs to be taken with the `registered_encoders` line in
`__init__`. Could this line be put somewhere to activate it only when the
`lazy_import` of `linear_code` gets dereferenced?
Best,
Johan
--
Ticket URL: <http://trac.sagemath.org/ticket/18376#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
