#19226: some (collinearity graphs of) GQ(q-1,q+1)
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_work
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 4076a47f7b7ec9c4a6d7e161429e25b0bc5231a1
Report Upstream: N/A | Stopgaps:
Branch: |
u/dimpase/GQ |
Dependencies: |
#19136 |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Hello Dima,
Here is a first-pass review.
- `coordinates`: why not a boolean? Its default value is `None`, and you
did not
mention its type in the documentation.
- Docstrings of the two new classes: we usually describe what exactly the
function builds before the input section.
- Could you add a link toward the wikipedia page on generalized
quadrangles? I
do not believe that we have a definition of that in Sage yet.
- The value of `check` arguments is usually `True`.
- As we usually disable checks when calling those functions internally (we
only
check whatever is returned to the user), you may be a bit less careful
when
you check that the hyperoval is indeed an hyperoval, e.g.:
`Pi.trace(O).is_uniform(2)` or something (I did not check exactly yet).
- `checkhyperoval` -> `check_hyperoval`
- why do you name `O` the hyperoval, given that you have a `hyperoval`
variable?
Use that second name instead?!
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19226#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
