#18468: Bott Bundles, second attempt
-------------------------------------+-------------------------------------
Reporter: caravantes | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone:
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | d12715b44d9db3120682d46964d98468b1e8ae39
u/caravantes/bott_bundles_2nd_attempt| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vbraun):
Since there is a lot more that one could do with flag manifolds I'd
suggest a new directory `sage/geometry/flag_manifold` and at least
separate files for the base space and bundles.
Can you go through the comments and
* remove everything that is not needed: `# nu[j]=nu[j+1]-1` and so on
* remove debug print statements
* translate comments to English, I don't speak Spanish and have no idea
what you mean
Style guide issue: INPUT has two dashes between name and description
http://doc.sagemath.org/html/en/developer/coding_basics.html#the-
docstring-of-a-function-content
{{{
INPUT:
- ``p`` -- (default: 2) a positive prime integer.
}}}
Integration with the rest of Sage: object should at least inherit from
!SageObject and use `_repr_` instead of `__repr__`. There is a lot more,
e.g. the semigroup structure on bundles etc but thats at least a start.
Constructors (and methods in general) should never print anything as side
effect, otherwise you can't really use them as building blocks elsewhere.
Only `_repr_` should return a description. If you want a more detailed
description, add a special method for that (`explain()` or so).
Instead of `.Q()`, consider more descriptive names like
`.universal_quotient_bundle()`. Tab completion will then be much more
useful. Or collect them into an intermediate property like
`.bundle.universal_quotient()` (see also #15328)
--
Ticket URL: <http://trac.sagemath.org/ticket/18468#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
