#17715: AsymptoticTerm
-------------------------------------+-------------------------------------
Reporter: behackl | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.9
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: asymptotics, | Reviewers: Daniel Krenn, Clemens
gsoc15 | Heuberger
Authors: Benjamin Hackl | Work issues:
Report Upstream: N/A | Commit:
Branch: | b22a24b09af01226e100bdb69847495e806e1c53
u/cheuberg/asy/asymptoticTerm | Stopgaps:
Dependencies: #17600, #18930, |
#19237 |
-------------------------------------+-------------------------------------
Changes (by cheuberg):
* status: needs_review => needs_info
* commit: 67a73cabf434ab2d6642db0b9e5e8eeec9767feb =>
b22a24b09af01226e100bdb69847495e806e1c53
Comment:
Replying to [comment:38 behackl]:
> In fact, we only need the comparison of the underlying growth. I've
deleted `TermWithCoefficient._le_` and rewritten the documentation of
`GenericTerm.__le__` and `GenericTerm._le_` in order to reflect that.
>
> As this is--as you already said--a rather technical class, I think that
it can be justified if `<=` only compares growth. However, if we follow
this approach, then `x <= 2*x` and `2*x <= x` would both yield `True`, but
`x == 2*x` would be false (because as far as I can remember, we need `==`
to actually check if the coefficients are the same too, somewhere in the
`AsymptoticRing`). Any thoughts?
First, I do not know what the next tickets want to see, whether `<=` has
to be antisymmetric or not.
On the other hand, elements of equal growth will always absorb each other
and not be elements of the same asymptotic expansion, anyway?
Second, where is the implementation of equality of growth terms?
If in doubt, I would say that `x` and `2x` are incomparable in order to
save antisymmetry.
Apart from that, I reviewed your changes, added a few reviewer commits
(please cross-review).
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=ce7e2a379d666b4ff51fd5ed5de84229a27e861d
ce7e2a3]||{{{Trac #17715: avoid the use of repr in doctest}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7b29b28553796c9ca51f31ce74e66cef489d42e6
7b29b28]||{{{Trac #17715: do not include "the" in internal link texts}}}||
||[http://git.sagemath.org/sage.git/commit/?id=b22a24b09af01226e100bdb69847495e806e1c53
b22a24b]||{{{Trac #17715: Fix ReSt error}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17715#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
