#19191: LatticePoset: add is_planar()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__add_is_planar__|
da6a1f9536ac362eef45f565515c752afdf9c84f
Dependencies: #19193 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> Well, mathematicians do not always behave logically. `:=)`.
`-_-`
> 1) Is it technically possible to give positive review to a ticket like
this, as this depends on closed ticket not yet at newewst beta?
The only thing that we must preserve is Volker's own happiness. It does
not matter what you and I have on our hard drive: when a ticket is closed,
it means that Volker's latest release contains the ticket. So you can
assume that it is already applied.
> 2) This obviously needs clarification in documentation. But `NOTE` or
even `WARNING`? It would say that `NOTE` is enought.
I agree. I only have a note in the version I am working on.
> 3) Is there easy way to undo last commit on ticket?
Yeah yeah. Look at 'git rebase -i', I use this all the time (look for
'squashing'). But don't worry about this, I am working on the branch and
will push it shortly.
I still hesitate over this `is_planar` and `is_upward_planar`. If you
really think that the first is better then let's do this, but if you
believe that anybody who looks for `is_planar` would also think of trying
`is_upward_planar` then the second is obviously safer. Tell me how you
want it done, and I will update the branch accordingly.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19191#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
