#19043: Move configuration part of build/make/install to configure
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  build              |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/move_install_to_configure|  
4178b80c3ff5ce8e1753bffe48f32dc5bcccb728
   Dependencies:  #18885, #19187     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 I don't care about having a "perfect" history (and normally review the
 final diff from `develop`).

 Overall it looks good from my testing. However, I'm not quite sure about
 this

 > There is an important change for developers: any change to the list or
 versions of packages will require a run of `./configure` to take effect.

 To make sure I understand correctly, does this mean that anytime we want
 to do a version bump of packages (or add one), we have to manually run
 `$SAGE_ROOT/configure`? If so, then I think we should put something about
 this in the spkg development guide. Also, is `configure` updated on beta
 version changes or just on stable releases?

 Also is there a reason why you moved the "if root" test lower in the file?
 I would think we'd want such build failures to happen as early on as
 possible.

--
Ticket URL: <http://trac.sagemath.org/ticket/19043#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to