#19043: Move configuration part of build/make/install to configure
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  build              |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/move_install_to_configure|  
4178b80c3ff5ce8e1753bffe48f32dc5bcccb728
   Dependencies:  #18885, #19187     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_review => positive_review
 * reviewer:   => Travis Scrimshaw


Comment:

 Replying to [comment:11 jdemeyer]:
 > Replying to [comment:10 tscrim]:
 > > To make sure I understand correctly, does this mean that anytime we
 want to do a version bump of packages (or add one), we have to manually
 run `$SAGE_ROOT/configure`?
 > Yes.
 >
 > > If so, then I think we should put something about this in the spkg
 development guide.
 > OK, I see your point. I'd rather make that a separate ticket, there
 might be other changes to the spkg development guide I want to make.

 Fair enough, but let's make that spkg dev guide update ticket a blocker.

 > > Also, is `configure` updated on beta version changes or just on stable
 releases?
 > All releases, beta and stable. So in practice, you only really need to
 run `./configure` manually if you yourself are working on a package (as
 author or reviewer). If the package upgrade happens as part of a Sage
 version bump, no special action is needed.

 Thanks for the explanation.

 > > Also is there a reason why you moved the "if root" test lower in the
 file?
 > There is no real particular reason, it felt more logical to put it where
 it currently is.
 >
 > > I would think we'd want such build failures to happen as early on as
 possible.
 > Why?

 I feel that some of those configuration steps could take some time, just
 to have it fail for an unrelated reason. However I don't really care about
 this; it was more out of curiosity.

--
Ticket URL: <http://trac.sagemath.org/ticket/19043#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to