#18587: cartesian products of growth groups
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:  asymptotics,       |    Reviewers:  Clemens Heuberger
  gsoc15                             |  Work issues:
        Authors:  Benjamin Hackl,    |       Commit:
  Daniel Krenn                       |  7f209ea7928606090e597d0633685649739932b8
Report Upstream:  N/A                |     Stopgaps:
         Branch:  u/behackl/asy      |
  /growth-group-cartesian            |
   Dependencies:  #18223, #18586,    |
  #18930                             |
-------------------------------------+-------------------------------------

Comment (by cheuberg):

 Replying to [comment:25 behackl]:
 > Replying to [comment:22 cheuberg]:
 > > The current code makes some effort to recognize `**` in
 `create_key_and_extra_args`, but `**` is not recognized in
 `create_object`.
 >
 > Minor discrepancies like this are fixed on the cleanup ticket #19083. No
 need to introduce additional merge conflicts here.

 ok.

 > > > Also, I think that we should restrict building cartesian products of
 growth groups such that a factor may only occur once (currently, `x^ZZ *
 x^ZZ` is possible). I'll discuss this with Daniel.
 > >
 > > that might be hard.
 > >
 >
 > Turns out that this is very true. We will start with disallowing certain
 products like `x^ZZ * x^ZZ` and `x^ZZ * x^QQ` in the cleanup ticket.
 Altering the factory here only produces more merge conflicts with #19083
 (the entire factory is rewritten there, meaning that the code would have
 to be written twice).

 ok.

 This is a conditional positive review from my side: conditional on the
 dependency #18223.

--
Ticket URL: <http://trac.sagemath.org/ticket/18587#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to