#18587: cartesian products of growth groups
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:  asymptotics,       |    Reviewers:  Clemens Heuberger
  gsoc15                             |  Work issues:
        Authors:  Benjamin Hackl,    |       Commit:
  Daniel Krenn                       |  74547e6aac076261a6f7da6577d771eb9a830e60
Report Upstream:  N/A                |     Stopgaps:
         Branch:  u/dkrenn/asy       |
  /growth-group-cartesian            |
   Dependencies:  #18223, #18586,    |
  #18930                             |
-------------------------------------+-------------------------------------
Changes (by dkrenn):

 * commit:  7f209ea7928606090e597d0633685649739932b8 =>
     74547e6aac076261a6f7da6577d771eb9a830e60


Comment:

 Replying to [comment:26 cheuberg]:
 > This is a conditional positive review from my side: conditional on the
 dependency #18223.

 Merged in #18223 and adapted code. Please cross-review...and set it to
 positive ;)
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=70aa9c4fa3c8711fb7dc4aea446d4624d2a27803
 70aa9c4]||{{{rename CartesianProductPosets to CartesianProductPoset}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=f21990d0b55e665aed89b8aef0f862eef59d6368
 f21990d]||{{{code-simplify CartesianProduct assignment}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=8f9a61942e14254ec028924bccf918774fb57cf6
 8f9a619]||{{{add a doctest dealing with coercion while comparing}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=3b923b73b72bf3a6a7c4fa7f144fa27cc12e83f8
 3b923b7]||{{{Merge branch 'u/dkrenn/cat/cartesian-product-posets' of
 trac.sagemath.org:sage into t/18587/asy/growth-group-cartesian}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=74547e6aac076261a6f7da6577d771eb9a830e60
 74547e6]||{{{fix code after changes by previous merge}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18587#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to