#19290: MatroidUnion _rank accept any iterator, partition accept empty partition
-------------------------------------+-------------------------------------
       Reporter:  chaoxu             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  trivial            |    Milestone:  sage-6.9
      Component:  matroid theory     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Chao Xu            |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/chaoxu/matroid_union             |  4f501fbc5cdc0958d148bfe98b42a3a571a337e5
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by Rudi):

 * cc: Rudi (added)
 * component:  PLEASE CHANGE => matroid theory


Comment:

 Hi Chao,

 It is OK if underscored methods like ._rank are picky about the kind of
 input they can handle. The idea behind having both .rank() and ._rank() is
 that .rank() should be convenient to use (by checking the input, possibly
 reformatting it), and ._rank() as efficient as possible (by assuming the
 input is of the right form).

 So unless there is no efficiency hit whatsoever, I don't like the idea of
 adjusting ._rank to accept more varied input.

--
Ticket URL: <http://trac.sagemath.org/ticket/19290#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to