#19337: Improve asteroidal triples code
-------------------------------------+-------------------------------------
Reporter: dcoudert | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: David Coudert | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dcoudert/asteroid | e32015d13649c7df56362fc9fd2b57937f465705
Dependencies: #19334 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:11 vbraun]:
> I'd recommend the C99 `int_fast32_t` type
-1.
Why should this graph code use a type of at least 32 bits? Where does the
arbitrary number 32 come from? Why not `int_fast16_t` or `int_fast64_t`
then?
If you don't want `int`, I'd go with `long` then which is also guaranteed
to be at least 32 bits and which matches the actual return type of
`bitset_first_in_complement()`.
> you should never use the old `int` / `long` except to match legacy
libraries, its bad style and very hard to write 100% standards-compliant
code.
Really, why that? I would say that you should always use types like `long`
unless you need a specific bit-length.
--
Ticket URL: <http://trac.sagemath.org/ticket/19337#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
