#19337: Improve asteroidal triples code
-------------------------------------+-------------------------------------
Reporter: dcoudert | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: David Coudert | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dcoudert/asteroid | e32015d13649c7df56362fc9fd2b57937f465705
Dependencies: #19334 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> About the "fastest on the target system": that very much depends on the
application. On 64-bit systems, it could easily be a 64-bit type. If
you're making arrays of those (it seems that you do), you can end up
slower than `int32_t` because of the larger memory accesses.
Yes yes, I agree.
> PS: I realize that we're bikeshedding here. I'm not really against
`int_fast32_t`, I just wouldn't recommend it in this case. I would advice:
if you're certain(!) that 32 bits is enough, use `int32_t`. Otherwise, use
`long`.
Sooo... Would you say that there is actually *anything* that needs be
changed in this file? We use fixed-size types, they are unsigned because
that's what the data structure expects, and the change in Cython has been
fixed by Volker with a cast.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19337#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
