#19073: categorial constructions, pushout and coercions (extended) for
asymptotic
ring and growth groups
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: asymptotics | Reviewers: Clemens Heuberger
Authors: Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: u/cheuberg/asy | e2070b1eade3c10b528757d362d63db499d7e5e6
/groups-coercion | Stopgaps:
Dependencies: #17600, #17716, |
#18930, #18182, #19028, #18587, |
#18223, #18586 |
-------------------------------------+-------------------------------------
Changes (by cheuberg):
* status: needs_review => needs_work
* reviewer: => Clemens Heuberger
Old description:
> Extend coersions and deal with pushout constructions.
>
> Seealso meta ticket #17601
New description:
Extend coercions and deal with pushout constructions.
See also meta ticket #17601.
--
Comment:
I reviewed this ticket without reviewing its dependency #18182. I have
added a few reviewer commits.
Here are some further comments.
1. `growth_group.combine_exceptions`: missing INPUT and OUTPUT blocks
2. Why is the default category now a monoid instead of a group?
3. `GenericGrowthGroup._pushout_`:
- explain why there is no common canonical parent for objects with
parents: `Growth Group QQ^x` and `Growth Group x^QQ` (commutativity of
pushouts vs. non-commutativity of cartesian products of growth groups with
the same generator?)
- What is the role of the lines
{{{
if isinstance(other, GenericGrowthGroup):
pass
}}}
4. `growth_group_cartesian.merge_overlapping`:
- add more information to docstring: missing INPUT: and OUTPUT: blocks
- `find_mergedoverlapping_index`: `key` is evaluated frequently
5. `_convert_factors_`: remove `list` in penultimate line of code.
6. `TermWithCoefficientMonoid._element_constructor_`: what is the point of
catching and immediately re-raising an exception in
{{{
try:
return self.element_class(self, data, coefficient)
except:
raise
}}}
7. `AsymptoticRing.__init__`: why is an `Asymptoticring` now a poset?
--
Ticket URL: <http://trac.sagemath.org/ticket/19073#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
