#19073: categorial constructions, pushout and coercions (extended) for
asymptotic
ring and growth groups
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.9
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: asymptotics | Reviewers: Clemens Heuberger
Authors: Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: u/dkrenn/asy | 8a32f1fa6d04cc3364430ece45895069ef7d5352
/groups-coercion | Stopgaps:
Dependencies: #17716, #18182, |
#19028, #18223, #18586 |
-------------------------------------+-------------------------------------
Changes (by dkrenn):
* status: needs_review => positive_review
* commit: 1583ffcaa805fe5021fa014dbe1ab99636466e5f =>
8a32f1fa6d04cc3364430ece45895069ef7d5352
Comment:
Replying to [comment:28 cheuberg]:
> Replying to [comment:22 dkrenn]:
> > Replying to [comment:20 cheuberg]:
> > > 2. Why is the default category now a monoid instead of a group?
> >
> > A monoid is all what is needed to make the asymptotic ring a ring. Of
course usually this will be a group to allow inversions in the ring, but
as a minimal requirement, we have Monoids()
>
> Ok, this explains why a `GenericGrowthGroup` is only a monoid.
>
> The derived classes `MonomialGrowthGroup` and `ExponentialGrowthGroup`,
however, will be groups in many cases.
> Perhaps this can be resolved in or after #19083.
Ok. Added it as a work issue on #19083.
> > > 3. `GenericGrowthGroup._pushout_`:
> > > - explain why there is no common canonical parent for objects with
parents: `Growth Group QQ^x` and `Growth Group x^QQ` (commutativity of
pushouts vs. non-commutativity of cartesian products of growth groups with
the same generator?)
> >
> > Documented.
>
> I reworded that and added further doctests.
Corrected PEP8.
> > > - `find_mergedoverlapping_index`: `key` is evaluated frequently
> >
> > Now cached.
>
> However, the helper functions only need the keys, I added a commit to do
so.
Thanks.
> Please cross-review my changes and add item 2. to the TODO list of
#19083 or, alternatively, open a ticket for that.
> After that, consider this to be a conditional `positive_review` from my
side, conditional on #18182.
Everything done.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=8a32f1fa6d04cc3364430ece45895069ef7d5352
8a32f1f]||{{{correct PEP8-spacings in doctest}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19073#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
