#19383: Up-down Posets, and Dimenson Poset
-------------------------------------+-------------------------------------
Reporter: kdilks | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/kdilks/updowndimension19383 | b2617ad137a2acbdb5b2844a23f4b09667e4b76d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):
* commit: => b2617ad137a2acbdb5b2844a23f4b09667e4b76d
Comment:
This was not marked as needs_review, but I'll comment anyway.
- Parameter checking is missing. Compare to `DiamondPoset`. Might be
easier to test like `if not n in NN or n<...`.
- `UpDownPoset(m,n)` should be `UpDownPoset(m, n)`.
- "fence" should be said in the documentation for googlers.
- `UpDownPoset` has unnecessary empty lines.
- Standard example should be explained, i.e. to tell what it is.
Should it be said that for `n >= 4` the standard example is only poset
with dimension `n` and `n` elements? Maybe no. (It is not true for `n=3`.)
Cases `n=1` and `n=2` are special - should them just be rejected as a
parameter?
What is best way to give parameters to `UpDownPoset`? To give the number
of elements or to give the number of minimal elements, or number of
maximal elements? I suppose that most users don't want `UpDownPoset(50,
6)` or similar, where the fence is kind of uncomplete.
Should every function have a `facade`-argument? Does not bother me, and
I'm not going to use non-facade posets, but it is kind on inconsistent
that some have it.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=b2617ad137a2acbdb5b2844a23f4b09667e4b76d
b2617ad]||{{{Initial implementation of updown posets and standard
example}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19383#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
