#18376: New encoding structure for linear codes
-------------------------+-------------------------------------------------
Reporter: | Owner:
dlucas | Status: needs_review
Type: | Milestone: sage-6.10
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
coding theory | Work issues:
Keywords: | Commit:
Authors: David | 43ec64071da5ff5e5f5f700fe61b53f8fa11330e
Lucas | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dlucas/encoder |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by jsrn):
Ok, things are looking pretty good. I had a look at your corrections after
my last review.
- Why is `LinearCodeGeneratorMatrixEncoder` registered on
`AbstractLinearCode` and not `LinearCode`?
- `encoder.py`: instanciated -> instantiated
- `codes.encoders` now contains `lazy_import`. Should be hidden
- `AbstractLinearCode` class doc: `__cmp` --> `__cmp__`. Should this and
`eq` have `:meth:`-tags on them?
- `AbstractLinearCode` class doc warning: perhaps "and `F` its base ring"
should be "and `F` is the base field of the code".
- `encoder.encode` doc: the newly added "`encode` is a partial function
..." should perhaps be made slightly less strong to not confuse readers:
"`encode` might be a partial function ...". Many encoders are going to be
complete.
Best,
Johan
--
Ticket URL: <http://trac.sagemath.org/ticket/18376#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
