#19459: Fix containment
-------------------------------------+-------------------------------------
       Reporter:  switzel            |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.10
      Component:  coercion           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Stefan Witzel      |    Reviewers:  Peter Bruin
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/switzel/fix_containment          |  3aa4bf2781f8ddb4a98316d252d0bc7a695f0c0a
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):

 * status:  needs_review => needs_work
 * reviewer:   => Peter Bruin


Comment:

 Two comments:
 - For every bug fixed, there needs to be a doctest showing that the bug
 has been fixed.
 - It is not clear to me that this is the correct fix; I would find it more
 appropriate to change the method `LaurentSeries.power_series()` to raise a
 `ValueError` instead of an `ArithmeticError` when given a Laurent series
 containing terms with negative exponents.  (It seems to me that
 `ArithmeticError` is intended rather for things like zero division and
 overflow.)

--
Ticket URL: <http://trac.sagemath.org/ticket/19459#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to