#19459: Fix containment
-------------------------------------+-------------------------------------
Reporter: switzel | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.10
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Stefan Witzel | Reviewers: Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/switzel/fix_containment | 3aa4bf2781f8ddb4a98316d252d0bc7a695f0c0a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:4 switzel]:
> * Concerning your second comment: I don't have a strong opinion on these
more philosophical questions (having no experience as a sage developer).
How is the decision procedure here? Should I just fix it the way you
suggest?
There is no formal decision procedure; the author(s) and reviewer(s)
should agree on a solution, and if nobody objects and the release manager
agrees to close the ticket, then that is it.
> [In practical terms my solution is more likely to keep bugs from beeing
detected (because an ArithmeticError might be caught by the containment
when it shouldn't) while your solution is more likely to break working
code (that tests for ArithmeticError that now become ValueErrors).]
I'd be surprised if there is any code that relies on
`LaurentSeries.power_series()` raising an `ArithmeticError`, but then
again, there may also be code that relies on `__contains__()` not catching
`ArithmeticError`... Anyway, I agree with Jeroen that a `TypeError` is
best in view of consistency.
--
Ticket URL: <http://trac.sagemath.org/ticket/19459#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
