#19473: FiniteDimensionalAlgebra.is_unitary is not sufficient
-------------------------------------+-------------------------------------
       Reporter:  darij              |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  algebra            |   Resolution:
       Keywords:  finite-            |    Merged in:
  dimensional algebra, linear        |    Reviewers:  Travis Scrimshaw
  algebra                            |  Work issues:  clear up
        Authors:  Darij Grinberg,    |  associativity requirement; if
  Travis Scrimshaw                   |  necessary, change superclass and
Report Upstream:  N/A                |  is_unitary method
         Branch:                     |       Commit:
  public/algebra/finite_dim_algebra_fixes-19473|  
0cfe0366fc527d2f692c835be3d40f60aa61c471
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by pbruin):

 Replying to [comment:5 tscrim]:
 > I would get rid of the `copy` attribute, instead make this a
 `UniqueRepresentation` (or perhaps a `UniqueFactory` so we can better
 control the cache key), and make the table a tuple of immutable matrices
 that gets set by the `__classcall_private__`.
 How does introducing `UniqueRepresentation` help in solving this ticket?
 Wouldn't it be better to do that on a separate ticket?
 > We also need to fix the category, which is wrong for non-associative,
 non-unital cases.
 I agree.  It is unfortunate that refining the category after
 initialisation is possibly problematic.

--
Ticket URL: <http://trac.sagemath.org/ticket/19473#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to