#19507: Cleanup category of FiniteDimensionalAlgebra
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers: Darij Grinberg
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/algebras/finite_dim_algebra_fixes-19507|
b2d0194f7e0f42b6c250c2d9b10896c4f8e8aaca
Dependencies: #19473 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:5 darij]:
> I have made a couple more trivial changes. With that, the code looks
good for me (thanks for doing this, Travis) -- although I am not exactly
sure why we need `UniqueRepresentation`.
It is encouraged that concrete parents be a subclass of
`UniqueRepresentation`, it gives us default `__hash__`, `__eq__` (which
actually, I think I just broke by not removing the `__eq__` and I will fix
shortly), and pickling, and it helps in standardizing the input.
> Travis: if you are OK with my changes, please set to positive_review.
And sorry for the delay in about everything I'm doing.
This isn't quite right:
{{{
- ``category`` -- (default:
``MagmaticAlgebras(k).FiniteDimensional().WithBasis()``
when ``assume_associative`` is ``False``, else
``Algebras(k).FiniteDimensional().WithBasis()``)
}}}
as the latter category also has the unital assumption and is not what the
code uses. I will tweak this when I fix the hash issue noted above.
--
Ticket URL: <http://trac.sagemath.org/ticket/19507#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
