#19507: Cleanup category of FiniteDimensionalAlgebra
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  tscrim
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  algebra            |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:  Darij Grinberg
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/algebras/finite_dim_algebra_fixes-19507|  
df80be003e837c1bcb05edfcbfc167e1ada2d592
   Dependencies:  #19473             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 I don't quite like this change:
 {{{#!diff
 -      without checking and sets the category as
 ``category.Associative()``
 +      without checking, and the category is set to
 +      ``category.Associative()``
 }}}
 as it separates out the second phrase from the first part of the sentence.
 I would prefer to revert this change, perhaps also changing the `as` to a
 `to`. Otherwise LGTM.

--
Ticket URL: <http://trac.sagemath.org/ticket/19507#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to