#18043: Support for HyperbolicPlane() in modform_hecketriangle
-------------------------------------+-------------------------------------
Reporter: jj | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.10
Component: modular forms | Resolution:
Keywords: hecke triangle | Merged in:
hyperbolic | Reviewers:
Authors: Jonas Jermann | Work issues:
Report Upstream: N/A | Commit:
Branch: | e9777f4745743eb8f68cc11ff3217d67e2dfa528
u/jj/hecke_hyperbolic | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
I will trust you that the math is sound (better if there is a quick
reference I can check). Here is a technical review.
- You might want to consider implementing a `_act_on_` for the Hecke
triangle group or `_acted_upon_` or `_get_action_` for the points of the
hyperbolic plane.
- I believe this comment is done by `as_isometry`:
{{{
# TODO: Make it possible to interpret elements as isometries of
the HyperbolicPlane
# and possibly use/implement actions using the
HyperbolicPlane model
}}}
- The name `as_isometry` is somewhat vague. Perhaps the more verbose
`as_hyperbolic_plane_isometry`? Unless it is well-understood that this
comes from isometries of the hyperbolic plane. You might also want to
consider adding a second argument that takes a model of the hyperbolic
plane (with the default being `'UHP'`).
- More of a side remark, the docstrings should be aligned as follows for
better typesetting in the html/pdf documentation:
{{{
INPUT:
- ``foo`` -- a really log docstring that wants to keep going should wrap
around and start at the same first non-whitespace character after the
bullet point object ``-``
}}}
- Another side remark, I would make this change:
{{{#!diff
- It is possible to evaluate at points of ``HyperbolicPlane()``:
-
- ::
+ It is possible to evaluate at points of ``HyperbolicPlane()``::
}}}
Both of the side remarks do not need to be addressed for me to set this to
a positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/18043#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
