#18043: Support for HyperbolicPlane() in modform_hecketriangle
-------------------------------------+-------------------------------------
       Reporter:  jj                 |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  minor              |    Milestone:  sage-6.10
      Component:  modular forms      |   Resolution:
       Keywords:  hecke triangle     |    Merged in:
  hyperbolic                         |    Reviewers:  Travis Scrimshaw
        Authors:  Jonas Jermann      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  9fba87a45127502a30bfcf3dab393807800f828f
  u/jj/hecke_hyperbolic              |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_review => positive_review


Comment:

 Replying to [comment:14 jj]:
 > Yes, I'm aware regarding actions & coercions. But the statement "p in
 CC" already takes care of that. I dont see a problem or did I miss
 something?

 I think I misunderstood your comment in the code.

 > I'm glad to hear the ticket is ready for positive review. I won't make
 any changes anymore so you can set it to positive review. I don't think
 I'm supposed to set it myself (?).

 You could have as I said it was okay. However, I'll just do it now. Thanks
 for your work on this.

--
Ticket URL: <http://trac.sagemath.org/ticket/18043#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to