#19494: Make finite word method nb_subword_occurences_in much faster
-------------------------+-------------------------------------------------
Reporter: | Owner:
slabbe | Status: needs_info
Type: | Milestone: sage-6.10
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Vincent Delecroix
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 0d9247f733118d16ce49cbc38b9f8e9e92791a28
Sébastien Labbé | Stopgaps:
Report Upstream: N/A |
Branch: |
u/slabbe/19494 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Replying to [comment:9 slabbe]:
> Replying to [comment:7 vdelecroix]:
> > Hola Sebastien,
>
> Hola !! Como esta tu en el Chile ahora!?
>
> > Here is an example where `original` is much faster
>
> How did you come up with this example? I mean what should be the
heuristic for when using the recursive or the matrices implementation?
If the result is 0 then the recursive version is likely to be much faster.
Roughly speaking, for matrices the computational time is independent on
the size of the result whereas for the recursive version it is
proportional to it.
However, the default should definitely be with matrices.
> > So we should definitely keep it.
>
> I renamed it `'recursive'`.
>
> > Note that the old implementation suffers several problems
>
> Yes. I have seen that...
>
> > What do you think?
>
> Ok, let me take a deeper look at it and see if I can remove bad Python
uses.
Does not matter so much for the sake of this ticket. You can add a comment
somewhere that the code can be improved.
--
Ticket URL: <http://trac.sagemath.org/ticket/19494#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
