#19508: Implementing RijndaelGF
-------------------------------------+-------------------------------------
Reporter: tgagne | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: cryptography | Resolution:
Keywords: cryptography, | Merged in:
aes, rijndaelgf | Reviewers: Martin Albrecht
Authors: Thomas Gagne | Work issues:
Report Upstream: N/A | Commit:
Branch: u/tgagne | faa7920d70beb59d79335e9bfdd3bcd00ea22429
/rijndael-gf | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tgagne):
* status: needs_work => needs_review
Comment:
Thanks so much for reviewing this, Martin!
A couple responses to some of your comments:
1. Looking more into how SR operates and its `gf2` mode, I realize that
`mq.SR()` and `RijndaelGF` can indeed operate over the same state. I've
removed that error from the documentation.
2. While Rijndael-GF's primary function isn't necessarily algebraic
cryptanalysis, it's definitely similar enough to BES that your comment
about the purpose of the `mq` module has convinced me that Rijndael-GF
fits better into `mq`. I've now moved it there in the most recent commit.
4. `hex_to_GF` and `bin_to_GF` do actually use `self` by calling `self._F`
to return an element of the field. On the other hand, `GF_to_bin` and
`GF_to_hex` don't necessarily rely on `self` but they do use it for
printing error messages; does it make sense to remove the reference to
`self` in the error messages so that `@staticmethod` can be used? Also, I
agree that those functions might not have the best home in Rijndael-GF and
that a separate module might be better. Did you have in mind a more
general `string_to_field` module or were you thinking of a module more
specific to cryptography, since `hex_to_GF` for example only works when
the field is `F(2^(4n))`?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=faa7920d70beb59d79335e9bfdd3bcd00ea22429
faa7920]||{{{Changed a bit of documentation in Rijndael-GF which
incorrectly stated the}}}||
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=faa7920d70beb59d79335e9bfdd3bcd00ea22429
faa7920]||{{{Changed a bit of documentation in Rijndael-GF which
incorrectly stated the}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19508#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
