#19585: Improve efficiency of calling GAP functions
-------------------------------------+-------------------------------------
Reporter: jaanos | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: interfaces | Resolution:
Keywords: GAP functions | Merged in:
interface | Reviewers: Travis Scrimshaw
Authors: Janoš Vidali | Work issues:
Report Upstream: N/A | Commit:
Branch: | 31a173bccd732cb8d8b656d6882dcec074a87b7d
u/jaanos/improve_calling_gap_function-19585| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jaanos):
I agree with the change.
By the way, earlier in `Expect.__init__`, `_get_using_file` is set if the
''value'' is too long - I don't see how that helps (except when `is_name
== True`, but the new code also covers this case). So we can probably
remove that piece of code, too.
On the other hand, this comment
{{{
#!python
# idea: Joe Wetherell -- try to find out if the output
# is too long and if so get it using file, otherwise
# don't.
}}}
makes me wonder whether `_get_using_file == True` was meant that fetching
the result would be done using a temporary file (rather than using one to
communicate the variable name). But of course, a long command may give a
very short answer, and the output of a short command may be very long, so
this isn't something that can be decided here. Also, the only
`get_using_file` methods apart from the new one in `gap.py` are the
generic one in `interface.py` (which simply calls `get`), and one in
`lie.py` which raises a `NotImplementedError`. So we're probably safe
redefining the meaning, if that's what's happening here.
--
Ticket URL: <http://trac.sagemath.org/ticket/19585#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
