#18529: Topological manifolds: basics
-------------------------------------+-------------------------------------
Reporter: egourgoulhon | Owner: egourgoulhon
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: geometry | Resolution:
Keywords: topological | Merged in:
manifolds | Reviewers: Travis Scrimshaw
Authors: Eric Gourgoulhon | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0b08b114e03c063bd2e500ac900fd843fb12673b
public/manifolds/top_manif_basics | Stopgaps:
Dependencies: #18175 |
-------------------------------------+-------------------------------------
Comment (by egourgoulhon):
Replying to [comment:62 tscrim]:
>
> I will then start my refactoring. I will try to make every change as
granular as possible in the commits so we can cherry-pick changes if you
don't necessarily agree with them.
>
OK very good.
Have you noticed that some doctests failed in the latest commit? This due
to a typo: "coordintes" instead of "coordinates" in the replacement of
{{{
if self._restrictions != []:
substitutions = dict(zip(self._xx, coordinates))
}}}
by
{{{
if self._restrictions:
substitutions = {x: coordintes[i] for i,x in
enumerate(self._xx)}
}}}
in `chart.py`. By the way, why is the second form better than the first
one?
>
> How about this, let me make my changes and you can see what breaks or
how much things slow down and we will use that to decide what we should do
going forward. Does that sound reasonable to try?
Yes, absolutely!
--
Ticket URL: <http://trac.sagemath.org/ticket/18529#comment:63>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
