#19312: Update to pynac-0.5.0
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers:
Authors: Ralf Stephan | Work issues:
Report Upstream: N/A | Commit:
Branch: u/rws/19312-2 | 76733e4c003da3506ac1cc15bea61b7ca147de93
Dependencies: #19606 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Here are my current comments:
- I also don't understand the changes on comment:30.
- `decl_assume` and `decl_forget` aren't doctested.
- `raise TypeError('Cannot compare: ' + repr(self))`: I'm thinking that
should be a `ValueError` since it depends on the value of the value of the
expression. Also, to better conform with python, error messages are not
sentences and should not start with a capital letter.
- Could we change:
{{{#!diff
- if solution_dict is not True and solution_dict is not False:
+ if not isinstance(solution_dict, bool):
}}}
- I don't understand this change:
{{{#!diff
diff --git a/src/sage/geometry/hyperbolic_space/hyperbolic_isometry.py
b/src/sage/geometry/hyperbolic_space/hyperbolic_isometry.py
index 4840c05..f205b9c 100644
--- a/src/sage/geometry/hyperbolic_space/hyperbolic_isometry.py
+++ b/src/sage/geometry/hyperbolic_space/hyperbolic_isometry.py
@@ -1054,12 +1054,11 @@ def mobius_transform(A, z):
TypeError: A must be an invertible 2x2 matrix over the complex
numbers or a symbolic ring
The matrix can be symbolic or can be a matrix over the real
- or complex numbers, but must be invertible::
-
- sage: (a,b,c,d) = var('a,b,c,d');
- sage: mobius_transform(matrix(2,[a,b,c,d]),I)
- (I*a + b)/(I*c + d)
+ or complex numbers, but must be provably invertible::
+ sage: (b,c) = var('b,c');
+ sage: mobius_transform(matrix(2,[1,b,c,b*c+1]),I)
+ (b + I)/(b*c + I*c + 1)
sage: mobius_transform(matrix(2,[0,0,0,0]),I)
Traceback (most recent call last):
...
}}}
I feel it obfuscates what the Möbius transform does.
--
Ticket URL: <http://trac.sagemath.org/ticket/19312#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
