#19619: Simplify words.py
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/19619 | 661588fc93cd6d90caec33d1adfe5755983ae871
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:10 slabbe]:
> Is it ready for review? I saw a TODO in the diff...
Read for review. The TODO can be removed. It was because of the
`cmp_letters` method. Now its status is decided on construction as follows
{{{
if alphabet.cardinality() == Infinity or \
(alphabet.cardinality() < 36 and
all(alphabet.unrank(i) > alphabet.unrank(j) for
i in range(min(36,alphabet.cardinality())) for j in
range(i))):
self.cmp_letters = cmp
else:
self.cmp_letters = self._cmp_letters
}}}
where `_cmp_letters` is the previous version which compares by ranking in
the alphabet. It is of course not ideal, but I think that we should get
rid of this `cmp_letters` anyway.
--
Ticket URL: <http://trac.sagemath.org/ticket/19619#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
