#19619: Simplify words.py
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/19619 | bcc2d8678ed56cb0dca16b4647811834268b36b0
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by slabbe):
The ones at lines 302 and 1721 are not deprecated. The method
`_cmp_letters` is tested with `cmp_letters` (?). To my opinion, the two
methods that are deprecated should also be doctested. It will take three
lines, show the user how to use those methods. Maybe with a pickle through
an indirect doctest, I don't know. For the one at line 2429, say why this
method must exist, it contains only "pass", why?
{{{
------------------------------------------------------------------------
SCORE src/sage/combinat/words/words.py: 95.5% (63 of 66)
Missing documentation:
* line 1721: def _element_classes(self)
* line 2424: def __setstate__(self, state)
* line 2429: def _element_constructor_(self)
Possibly wrong (function name doesn't occur in doctests):
* line 302: def _cmp_letters(self, letter1, letter2)
------------------------------------------------------------------------
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/19619#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
