#19619: Simplify words.py
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: Sébastien Labbé
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/19619 | 7ee2e3c52d273b51cef7993a5e605918a12a99ac
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by slabbe):
* status: needs_review => needs_work
Comment:
- Are sure that we do not prefer the `__call__` to be implemented in one
place in `AbstractLanguage`? Lot of documentation is a copy paste...
- Argument `length` in unused in `InfiniteWords.__call__`.
- Documentation of `InfiniteWords.__call__` should not mention list, str,
tuple, char and the length argument.
- The below lines in `FiniteWords._word_from_word` seem useless. Same
comment for `InfiniteWords._word_from_word`:
{{{
#!python
from sage.combinat.words.finite_word import CallableFromListOfWords
if isinstance(data._func, CallableFromListOfWords):
# The following line is important because, in this case,
# data._func is also a tuple (indeed
# CallableFromListOfWords inherits from tuple)
datatype = "callable"
}}}
- `Words_n.__call__` should include a `INPUTS:` block
- The following imports are not used:
{{{
from sage.misc.mrange import xmrange
from sage.structure.parent import Set_PythonType
from sage.combinat.combinat import InfiniteAbstractCombinatorialClass
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/19619#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
