#18928: A new structure for Reed-Solomon codes in Sage
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  dlucas                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.10
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:
  coding theory          |  Work issues:
       Keywords:         |       Commit:
        Authors:  David  |  0e828483e4674799ff0f8d6a328ccd854aef8cf1
  Lucas                  |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/jsrn/grs             |
   Dependencies:         |
  #18376                 |
-------------------------+-------------------------------------------------
Changes (by jsrn):

 * commit:  aed4aa279a390bbef9057c9d6c0dcc86d28589fd =>
     0e828483e4674799ff0f8d6a328ccd854aef8cf1


Comment:

 I read through everything. I've polished a number of doc-tests and doc-
 strings, both for clarity, correctness and paedagogy. Also, I've removed
 `unencode_nocheck` on the vector-style encoder (since the inherited one is
 much faster), and I've added input sanity checks to `encode` for the
 polynomial-style encoder.

 If you can accept my modifications, I give this ticket the green light.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=5578ea715c6ee6341e572c10b39fbd0d9709881e
 5578ea7]||{{{Fixes to field checks at construction. Some doc
 corrections}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=af21ded8f0e49397cc587ccadfc240fc5ddc3c61
 af21ded]||{{{Save private lists as tuples instead. Small changes to some
 docstrings and some examples.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=2323380658f9e8612ed5cc92f68bc64ee74b0683
 2323380]||{{{GRS parity check matrix from the dual code}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=667f89f83846a2ad34efdcee1a506c0c62c68edc
 667f89f]||{{{rm special impl. of
 GRSEvaluationVectorEncoder.unencode_nocheck}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=8733405ab5be96dff84e72543121e79ac77e6a66
 8733405]||{{{Some improved doc-strings and doc-tests}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=229b5cf5786019a256e5c6a442572eff870f0225
 229b5cf]||{{{Some code beautification}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=fe7e9debca33f40e2e9208d002d15e58ac781ff2
 fe7e9de]||{{{Sanity-checks on input for
 GRSEvaluationPolynomialEncoder}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=6e7013b8666b9490ea14e349bdbd96b586f048ff
 6e7013b]||{{{Small doc-string improvements in linear_code and encoder}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=0e828483e4674799ff0f8d6a328ccd854aef8cf1
 0e82848]||{{{More small docstring improvements}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18928#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to