#17220: Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from 
Arb)
-------------------------------------+-------------------------------------
       Reporter:  cheuberg           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  numerical          |   Resolution:
       Keywords:  arb, acb_mat,      |    Merged in:
  complex balls, matrix              |    Reviewers:
        Authors:  Clemens Heuberger  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  41263f09f24efbb2178bba50e35c8f17b959c11c
  u/mmezzarobba/acb_mat              |     Stopgaps:
   Dependencies:  #18546, #19063,    |
  #19152                             |
-------------------------------------+-------------------------------------
Changes (by mmezzarobba):

 * commit:  77b68c3748c30469a8f3fd969cca0f5cf0dcc998 =>
     41263f09f24efbb2178bba50e35c8f17b959c11c
 * branch:  u/cheuberg/matrix/acb_dense => u/mmezzarobba/acb_mat


Comment:

 Hello,

 So I had a look and added a few reviewer patches with minor changes. Two
 questions:
 - are the functions `matrix_to_acb_mat` & co really useful?
 - your `__init__` deviates a little bit from the logic in
 `Matrix_generic_dense.__init__`, so that for example the following no
 longer works, is that intentional?
 {{{
 sage: Pol.<x> = QQ[]
 sage: pol = 1 + x + x^2
 sage: Mat = MatrixSpace(CBF, 3, 1)
 sage: Mat(pol)
 [1.000000000000000]
 [1.000000000000000]
 [1.000000000000000]
 }}}
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=41263f09f24efbb2178bba50e35c8f17b959c11c
 41263f0]||{{{#17220 cosmetic fixes + a few tests}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/17220#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to