#17220: Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from
Arb)
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.10
Component: numerical | Resolution:
Keywords: arb, acb_mat, | Merged in:
complex balls, matrix | Reviewers: Marc Mezzarobba
Authors: Clemens Heuberger | Work issues:
Report Upstream: N/A | Commit:
Branch: | c095ddd94dadc5523ebec3c0216dc0e2b25fd1f8
u/cheuberg/acb_mat | Stopgaps:
Dependencies: #18546, #19063, |
#19152 |
-------------------------------------+-------------------------------------
Changes (by mmezzarobba):
* status: needs_review => positive_review
Comment:
The branch merges correctly in spite of the red link, and looks good to
me.
Replying to [comment:34 cheuberg]:
> > > > - your `__init__` deviates a little bit from the logic in
`Matrix_generic_dense.__init__`, so that for example the following no
longer works, is that intentional?
[...]
> fixed. Do you want to open a ticket for integer matrices?
Thanks. I've opened #19700 for the other cases.
> > And one more thing I missed on first reading: I don't understand the
part that says “`copy` - ignored (since complex balls are immutable)” in
the docstring of `__init__`. Based on the code and documentation of
`MatrixSpace.matrix()`, it seems to me that this parameter is supposed to
control whether the matrix itself—not its entries—is copied.
>
> I do not know how to implement `copy=False`. I do not think that it can
be done as in `matrix_generic_dense` because we have a somewhat
specialized data structure here. Thus I still ignore `copy`, but tried to
rewrite the documentation.
Yes, I agree it is fine to always perform the copy.
--
Ticket URL: <http://trac.sagemath.org/ticket/17220#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
