#19632: Haemers srgs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_info
Type: | Milestone: sage-6.10
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: | Commit:
Authors: Dima | 954e30523288904bece76489f5c513a961f1335e
Pasechnik | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dimpase/haemers |
Dependencies: |
#19463, #19624 |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
* reviewer: => Nathann Cohen
Comment:
Hello Dima,
As the end of december is coming fast, I started this review before the
next beta. I added a commit at public/19632 that cleans a couple of
things, and simplifies some code too. It would be really great if you
could start thinking of what your computer does when you give it
instructions, because a lot of computations was done for nothing.
Two remarks:
- For me the following doctest is too long, even for a "#long" doctest.
Recently some guys were trying to figure out how to do something like
"#long 2m" doctests for a better filtering.
{{{
sage: %time g=graphs.HaemersGraph(8); g
CPU times: user 11.1 s, sys: 20 ms, total: 11.1 s
Wall time: 11.1 s
}}}
- It seems that `partition` is not a partition of the vertex set but a
partition of ... a partition of G into independent sets. Would it be
possible to change the terminology a bit to avoid confusion?
Thanks,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19632#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
