#19229: Bug in elliptic curve Galois Representation
-------------------------------------+-------------------------------------
       Reporter:  cremona            |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  elliptic curves    |   Resolution:
       Keywords:  Galois             |    Merged in:
  representations                    |    Reviewers:
        Authors:  John Cremona       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/cremona/19229    |  df3d3f7c5819198be47c0f3dc8d7419066cee34c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 What's the point of this "poor man's caching", why not use
 `cached_method`?
 {{{
 #!diff
 +        self._has_cm = E.has_cm()
 +        self._has_rational_cm = E.has_rational_cm()
 }}}

 There seems to be an indentation problem with
 {{{
 #!diff
 + # ramified primes
 }}}

 Funny spacing:
 {{{
 #!diff
 + if E .has_bad_reduction(P):
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/19229#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to