#19229: Bug in elliptic curve Galois Representation
-------------------------------------+-------------------------------------
Reporter: cremona | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.10
Component: elliptic curves | Resolution:
Keywords: Galois | Merged in:
representations | Reviewers:
Authors: John Cremona | Work issues:
Report Upstream: N/A | Commit:
Branch: u/cremona/19229 | 62accc077ff28e2306364abaa60199846e292fdd
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
Obvious question: what is the performance impact of the earlier CM checks?
It seems that the old code was careful to postpone CM checks.
All the methods where you added a check for CM should have a doctest for
the case when there is no CM. Many don't have such a doctest.
Like I said before, this should be replaced by real caching (you
implemented the caching, but forgot to remove this part):
{{{
#!diff
+ self._has_cm = E.has_cm()
+ self._has_rational_cm = E.has_rational_cm()
}}}
I think this comment is not very clear:
{{{
#!diff
+ # See #19229: can cause problems if this name is 'a' but it has
to be something!
+ F = NumberField(y**2 - a, 'grnf_a')
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/19229#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
