#19640: Do not drop LDFLAGS
-------------------------------------------------+-------------------------
Reporter: vbraun | Owner:
Type: defect | Status: closed
Priority: major | Milestone: sage-6.10
Component: packages: standard | Resolution: fixed
Keywords: | Merged in:
Authors: Volker Braun | Reviewers: François
Report Upstream: N/A | Bissey
Branch: | Work issues:
618651e0db7fdd4eeb94a3aef3811de877e3df8e | Commit:
Dependencies: | Stopgaps:
-------------------------------------------------+-------------------------
Changes (by leif):
* commit: 618651e0db7fdd4eeb94a3aef3811de877e3df8e =>
Comment:
Replying to [comment:11 fbissey]:
> It's just a mess
> {{{
> Singular/Makefile.in:SLDFLAGS = @SLDFLAGS@
> Singular/Makefile.in: $(LIBSINGULAR_LD) ${SLDFLAGS}
${LIBSINGULAR_FLAGS} -o libsingular.${SO_SUFFIX} \
> Singular/Makefile.in: $(LD) ${SLDFLAGS} -o $@ $^ -L${libdir}
${MP_LIBS} ${GLIBC_DYN_FIX}
> Singular/Makefile.in: $(LD) ${SLDFLAGS} -o $@ $^ ${GLIBC_DYN_FIX}
> Singular/Makefile.in: $(CXX) $^ ${PYTHON_MODULE_LDFLAGS} ${SLDFLAGS}
${PYTHON_MODULE_LIBS} ${LD_LIBC} -o $@
> Singular/Makefile.in: ${CXXG} ${CXXFLAGSG} ${SFLAGS} ${SLDFLAGS}
${LDFLAGS} -o $@ $^ ${MP_LIBS} ${GLIBC_DYN_FIX}
> Singular/Makefile.in: ${CXXG} ${CXXFLAGSG} ${SFLAGS} ${SLDFLAGS}
${LDFLAGS} -o $@ $^ ${MP_LIBS}
> Singular/Makefile.in: ${CXXP} ${CXXFLAGSP} ${SFLAGS} ${SLDFLAGS}
${LDFLAGS} -o $@ $^ ${MP_LIBS} ${GLIBC_DYN_FIX}
> Singular/Makefile.in: ${CXXP} ${CXXFLAGSP} ${SFLAGS} ${SLDFLAGS}
${LDFLAGS} -o $@ $^ ${MP_LIBS}
> kernel/Makefile.in:SLDFLAGS = @SLDFLAGS@
> kernel/Makefile.in: $(LD) ${SLDFLAGS} -o $@ $^
> kernel/Makefile.in: $(LD) ${SLDFLAGS} -o $@ $^
> kernel/Makefile.in: ${CXXP} ${CXXFLAGSP} ${SFLAGS} ${SLDFLAGS} $< -o
$@
> }}}
> Some bits of `singular` are using `LDFLAGS` but we would need to add it
wherever it is missing above, at least wherever `LD` is called.
Nope, `LDFLAGS` are meant to be passed to the ''compiler'', not directly
to the linker. (You'd frequently get syntax errors otherwise, because the
linker doesn't necessarily take the same or all of the options. The
compiler in contrast passes anything it doesn't understand verbatim to the
linker if applicable, so the opposite is not a problem.)
--
Ticket URL: <http://trac.sagemath.org/ticket/19640#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
