#19751: Implement a generic multiplication method for dense matrices
-------------------------------------+-------------------------------------
       Reporter:  mmezzarobba        |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-7.0
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Marc Mezzarobba    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mmezzarobba/genmatmult           |  77166d86df0c3d37eafbb0dd6fa61a962cf051ad
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work


Comment:

 > Changed, but why? Cython seems to be able to infer that type.

 I didn't check the C code. I didn't even know Cython could do that.


 Something else: replace
 {{{
 raise IndexError("Number of columns of left must equal number of rows of
 right.")
 }}}
 by an `ArithmeticError`. The same exception occurs in Sage as `IndexError`
 and as `ArithmeticError` but I think the latter is the most suitable.

 You also need to doctest this exception.

--
Ticket URL: <http://trac.sagemath.org/ticket/19751#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to