#19822: Fast polynomial evaluation fmpz_poly/ZZX with mpfr/mpfi input
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.0
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/19822 | 683cd0de16503dc913750fd7c417129409b010c6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
Some quick comments:
1. `only do` -> `only does`
2. What's the point of the `mpfr_rnd_t rnd` parameter, given that you
don't make any guarantees about exact rounding or rounding direction?
Given the code, the only sensible rounding mode is `MPFR_RNDN`.
3. Did you investigate special-casing small degrees (say, degree <= 1)?
4. Both `fmpz_poly_degree(poly)` and `ZZX_deg` return `long`, so the loop
variable must be `long` too.
--
Ticket URL: <http://trac.sagemath.org/ticket/19822#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
